Add Python3 CLI Commands by sushil490023 · Pull Request #5415 · Azure/azure-cli-extensions

sushil490023 · 2022-10-04T06:39:08Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

…ature-Auto

ghost · 2022-10-04T06:39:19Z

Thank you for your contribution sushil490023! We will review the pull request and get back to you soon.

yonzhan · 2022-10-04T09:02:20Z

automation

wangzelin007 · 2022-10-07T06:25:34Z

/azp run

azure-pipelines · 2022-10-07T06:25:45Z

Azure Pipelines successfully started running 1 pipeline(s).

zhoxing-ms · 2022-10-09T03:48:03Z

@sushil490023 Could you please resolve those CI issues?

src/automation/azext_automation/aaz/latest/automation/python3package/__cmd_group.py

src/automation/azext_automation/aaz/latest/automation/python3package/_create.py

src/automation/azext_automation/tests/latest/test_automation_scenario_manual.py

src/automation/azext_automation/aaz/latest/automation/python3_package/_list.py

src/automation/azext_automation/aaz/latest/automation/python3_package/_create.py

src/automation/azext_automation/aaz/latest/automation/python3_package/_delete.py

wangzelin007 · 2022-10-09T04:11:56Z

src/automation/azext_automation/aaz/latest/automation/python3_package/_show.py

+    """Retrieve the python 3 package identified by package name.
+
+    :example: Get Python3Package by Name
+        az automation python3-package  show --automation-account-name  "MyAutomationAccount"  --resource-group "MyResourceGroup " --name "PackageName"


Suggested change

az automation python3-package show --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup " --name "PackageName"

az automation python3-package show --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup" --name "PackageName"

Removed spaces Thanks for pointing out

wangzelin007 · 2022-10-09T05:25:53Z

@sushil490023,
What is the difference between python3_package and python3package directories?
Actually I compare the two directories and they use almost the same code.

wangzelin007 · 2022-10-09T05:30:11Z

@sushil490023,
May I ask if these example codes are automatically generated by codegen?
If these extra blanks are caused by codegen, we should let @kairu-ms known about this.

kairu-ms · 2022-10-09T06:06:07Z

@sushil490023, May I ask if these example codes are automatically generated by codegen? If these extra blanks are caused by codegen, we should let @kairu-ms known about this.

Examples are manually written in Workspace Editors right now.

sushil490023 · 2022-10-18T06:43:06Z

@sushil490023, What is the difference between python3_package and python3package directories? Actually I compare the two directories and they use almost the same code.

I have deleted python3package directories

zhoxing-ms · 2022-10-18T07:56:52Z

vcr.errors.CannotOverwriteExistingCassetteException: Can't overwrite existing cassette ('/mnt/vss/_work/1/s/src/automation/azext_automation/tests/latest/recordings/test_automation_software_update_configuration.yaml') in your current record mode ('once').
No match for the request (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/publishers/Canonical/artifacttypes/vmimage/offers/UbuntuServer/skus/18.04-LTS/versions?$top=1&$orderby=name%20desc&api-version=2022-08-01>) was found.
Found 1 similar requests with 1 different matcher(s) :

1 - (<Request (GET) https://management.azure.com/subscriptions/00000000-0000-0000-0000-000000000000/providers/Microsoft.Compute/locations/westus/publishers/Canonical/artifacttypes/vmimage/offers/UbuntuServer/skus/18.04-LTS/versions?$top=1&$orderby=name%20desc&api-version=2022-03-01>).
Matchers succeeded : ['method', 'scheme', 'host', 'port', 'path']
Matchers failed :
_custom_request_query_matcher - assertion failure :
None

@sushil490023 This is because the api-version of Compute RP in azure-cli-core has been upgraded (PR link: Azure/azure-cli#24036), so you need to re-record the tests related to Compute RP in the extension.

Please pull the latest main CLI code from the dev branch of Azure/azure-cli repo first, and re-record those failed tests locally and then pushing them into this PR

zhoxing-ms · 2022-10-21T02:26:24Z

src/automation/azext_automation/aaz/latest/automation/python3_package/_create.py

+    """Create or Update the python 3 package identified by package name.
+
+    :example: Add Python3 Package to automation account
+        az automation python3-package create --automation-account-name "MyAutomationAccount"  --resource-group "MyResourceGroup" --name "PackageName" --content-link "uri=https://PackageUri.com"


Suggested change

az automation python3-package create --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup" --name "PackageName" --content-link "uri=https://PackageUri.com"

az automation python3-package create --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup" --name "PackageName" --content-link "uri=https://PackageUri.com"

zhoxing-ms · 2022-10-21T02:32:49Z

src/automation/azext_automation/aaz/latest/automation/hrwg/_show.py

+    """Get a hybrid runbook worker group.
+    """


I see that examples have been added to commands under automation hrwg hrw group, but there still seems to be no examples for commands under automation hrwg group

i have added required examples

zhoxing-ms · 2022-10-21T02:36:31Z

Please add the description of PR changes in the HISTORY.rst. And if you want to release a new extension version for this PR, please also upgrade the version defined in setup.py.

…cli-extensions into feature-Auto

sushil490023 · 2022-10-21T06:22:33Z

Please add the description of PR changes in the HISTORY.rst. And if you want to release a new extension version for this PR, please also upgrade the version defined in setup.py.

Updated

zhoxing-ms · 2022-10-21T07:22:21Z

src/automation/HISTORY.rst


+0.2.1
++++++
+* `az automation python3-package`: Add new command group to support managing python3 Package operations.


Suggested change

* `az automation python3-package`: Add new command group to support managing python3 Package operations.

* `az automation python3-package`: Add new command group to support managing python3 package operations.

zhoxing-ms · 2022-10-21T07:23:52Z

src/automation/azext_automation/aaz/latest/automation/hrwg/_delete.py

+    """Delete a hybrid runbook worker group.
+
+    :example: Delete hybrid worker group
+        az automation hrwg delete --automation-account-name accountName --resource-group groupName  --name hybridrunbookworkergroupName


Suggested change

az automation hrwg delete --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName

az automation hrwg delete --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName

zhoxing-ms · 2022-10-21T07:24:45Z

src/automation/azext_automation/aaz/latest/automation/hrwg/_show.py

+    """Get hybrid worker group
+
+    :example: Get hybrid worker group
+        az automation hrwg show --automation-account-name accountName --resource-group groupName  --name hybridrunbookworkergroupName


Suggested change

az automation hrwg show --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName

az automation hrwg show --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName

zhoxing-ms · 2022-10-21T07:25:13Z

src/automation/azext_automation/aaz/latest/automation/hrwg/_update.py

+    """Update a hybrid runbook worker group.
+
+    :example: Update hybrid worker group
+        az automation hrwg update --automation-account-name accountName --resource-group groupName  --name hybridrunbookworkergroupName --credential "{name: credentialname}"


Suggested change

az automation hrwg update --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName --credential "{name: credentialname}"

az automation hrwg update --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName --credential "{name: credentialname}"

@kairu-ms I find it is easy to mistype extra spaces when he enters examples by Workspace Editors.
I'm not sure if this is a common problem. If so, could we trim the user's input to eliminate the extra spaces in Workspace Editors?

I've added a new task in CodeGen V2 project plan. We will fix it when work on examples validation.

wangzelin007 · 2022-10-21T08:07:24Z

@sushil490023,
May I ask you to add some scenario tests for those new commands?

az automation hrwg update
az automation hrwg hrw create/delete/show/update

sushil490023 · 2022-10-21T08:17:03Z

@microsoft-github-policy-service agree [company="Microsoft"]

sushil490023 · 2022-10-21T08:17:44Z

@microsoft-github-policy-service agree [company="Microsoft"]

wangzelin007 · 2022-10-21T08:18:58Z

@microsoft-github-policy-service agree company="Microsoft"

zhoxing-ms · 2022-10-21T08:25:26Z

May I ask you to add some scenario tests for those new commands?

az automation hrwg update
az automation hrwg hrw create/delete/show/update

@sushil490023 Since these commands are existing commands, you may can consider submitting a PR separately to supplement these test cases. So we can merge the PR first, and then review the PR for supplementing test cases. What do you think of it?

sushil490023 · 2022-10-21T08:28:39Z

May I ask you to add some scenario tests for those new commands?

az automation hrwg update
az automation hrwg hrw create/delete/show/update

@sushil490023 Since these commands are existing commands, you may can consider submitting a PR separately to supplement these test cases. So we can merge the PR first, and then review the PR for supplementing test cases. What do you think of it?

Yes i think that would be much helpful and i will create sperate PR for adding scenario test cases for left over test cases of Hybrid runbook worker

sushil490023 · 2022-10-21T08:28:55Z

@microsoft-github-policy-service agree company="Microsoft"

wangzelin007 · 2022-10-21T08:43:13Z

@microsoft-github-policy-service agree

wangzelin007 · 2022-10-25T07:24:31Z

Force skip license/cla checks to merge this PR.
@sushil490023,
I think you still need to fix the account issue, otherwise every PR of yours will have to force skip checks to merge.

azclibot · 2022-10-25T07:30:58Z

[Release] Update index.json for extension [ automation ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=11062&view=results

Sushil Upadhyay added 4 commits September 9, 2022 15:37

Add Python3 CLI Commands

bec3536

Update Linter exclusion rule for automation account parameter

cde2c2f

Added Test cases for PY3

1362d34

Merge remote-tracking branch 'origin/feature-AzureAutomation' into fe…

969c30d

…ature-Auto

sushil490023 requested a review from zhoxing-ms as a code owner October 4, 2022 06:39

ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 4, 2022

sushil490023 mentioned this pull request Oct 4, 2022

Add Python3 CLI Commands #5301

Closed

3 tasks

yonzhan assigned zhoxing-ms Oct 4, 2022

yonzhan requested a review from wangzelin007 October 4, 2022 09:02

yonzhan added this to the Oct 2022 (2022-11-01) milestone Oct 4, 2022

zhoxing-ms reviewed Oct 9, 2022

View reviewed changes

src/automation/azext_automation/aaz/latest/automation/python3package/__cmd_group.py Outdated Show resolved Hide resolved

zhoxing-ms reviewed Oct 9, 2022

View reviewed changes

src/automation/azext_automation/aaz/latest/automation/python3package/_create.py Outdated Show resolved Hide resolved

zhoxing-ms reviewed Oct 9, 2022

View reviewed changes

src/automation/azext_automation/tests/latest/test_automation_scenario_manual.py Outdated Show resolved Hide resolved

zhoxing-ms reviewed Oct 9, 2022

View reviewed changes

src/automation/azext_automation/aaz/latest/automation/python3_package/_list.py Outdated Show resolved Hide resolved

wangzelin007 reviewed Oct 9, 2022

View reviewed changes

src/automation/azext_automation/aaz/latest/automation/python3_package/_create.py Outdated Show resolved Hide resolved

wangzelin007 reviewed Oct 9, 2022

View reviewed changes

src/automation/azext_automation/aaz/latest/automation/python3_package/_delete.py Outdated Show resolved Hide resolved

wangzelin007 reviewed Oct 9, 2022

View reviewed changes

Updated Test cases recording with latest test cases

7b3a91f

Sushil Upadhyay added 2 commits October 18, 2022 13:29

Updated Test cases recording with latest test cases

990ab60

Merge branch 'main' into feature-Auto

ed74e8e

zhoxing-ms reviewed Oct 21, 2022

View reviewed changes

Sushil Upadhyay and others added 3 commits October 21, 2022 11:42

Updated Command with examples

ab5b2bd

Merge branch 'Azure:main' into feature-Auto

c5a301a

Merge branch 'feature-Auto' of https://github.com/sushil490023/azure-…

65456d6

…cli-extensions into feature-Auto

zhoxing-ms reviewed Oct 21, 2022

View reviewed changes

Updated Command with examples

7c91284

zhoxing-ms approved these changes Oct 21, 2022

View reviewed changes

wangzelin007 closed this Oct 21, 2022

wangzelin007 reopened this Oct 21, 2022

wangzelin007 approved these changes Oct 21, 2022

View reviewed changes

Azure deleted a comment from azure-pipelines bot Oct 21, 2022

wangzelin007 closed this Oct 21, 2022

wangzelin007 reopened this Oct 21, 2022

wangzelin007 merged commit d855cc2 into Azure:main Oct 25, 2022

	az automation python3-package show --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup " --name "PackageName"
	az automation python3-package show --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup" --name "PackageName"

	az automation python3-package create --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup" --name "PackageName" --content-link "uri=https://PackageUri.com"
	az automation python3-package create --automation-account-name "MyAutomationAccount" --resource-group "MyResourceGroup" --name "PackageName" --content-link "uri=https://PackageUri.com"

	* `az automation python3-package`: Add new command group to support managing python3 Package operations.
	* `az automation python3-package`: Add new command group to support managing python3 package operations.

	az automation hrwg delete --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName
	az automation hrwg delete --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName

	az automation hrwg show --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName
	az automation hrwg show --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName

	az automation hrwg update --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName --credential "{name: credentialname}"
	az automation hrwg update --automation-account-name accountName --resource-group groupName --name hybridrunbookworkergroupName --credential "{name: credentialname}"

Conversation

sushil490023 commented Oct 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related command

General Guidelines

About Extension Publish

Uh oh!

ghost commented Oct 4, 2022

Uh oh!

yonzhan commented Oct 4, 2022

Uh oh!

wangzelin007 commented Oct 7, 2022

Uh oh!

azure-pipelines bot commented Oct 7, 2022

Uh oh!

zhoxing-ms commented Oct 9, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangzelin007 commented Oct 9, 2022

Uh oh!

wangzelin007 commented Oct 9, 2022

Uh oh!

kairu-ms commented Oct 9, 2022

Uh oh!

sushil490023 commented Oct 18, 2022

Uh oh!

zhoxing-ms commented Oct 18, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhoxing-ms commented Oct 21, 2022

Uh oh!

sushil490023 commented Oct 21, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zhoxing-ms Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kairu-ms Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wangzelin007 commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sushil490023 commented Oct 21, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sushil490023 commented Oct 21, 2022

Uh oh!

wangzelin007 commented Oct 21, 2022

sushil490023 commented Oct 4, 2022 •

edited

Loading

zhoxing-ms Oct 21, 2022 •

edited

Loading

kairu-ms Oct 21, 2022 •

edited

Loading

wangzelin007 commented Oct 21, 2022 •

edited

Loading

sushil490023 commented Oct 21, 2022 •

edited

Loading

zhoxing-ms commented Oct 21, 2022 •

edited

Loading